Doing the minimum necessary to fix the jshint issues in the code

openpsa / jsgrid

Fork of last jqGrid version before license change

http://openpsa.github.io/jsgrid/

Other

28 stars 12 forks source link

Doing the minimum necessary to fix the jshint issues in the code #26

Closed meh-uk closed 9 years ago

meh-uk commented 9 years ago

This mean it can be built by grunt without having to use the force option. This should also mean that the code will "have" to stay clean (or at least cleanish) going forward.

meh-uk commented 9 years ago

Whether we fix this using my pull or another way I don't care, but I think we need to stop using force to build for 1.0.

flack commented 9 years ago

Yes, I agree that we should remove the need for force as soon as possible. The only reason I'm hesitating right now is that this will surely create more merge conflicts with @OlegKi's changes. But then again, we need to find a solution for that problem in any case..

meh-uk commented 9 years ago

Well you were right about conflicts :(.

flack commented 9 years ago

and the real problem is still before us: https://github.com/OlegKi/jqGrid/commit/cda5503b6e62ad8dae5310e49f5c703d95299111

meh-uk commented 9 years ago

See pull #83 for this done again.