openpsa / jsgrid

Fork of last jqGrid version before license change
http://openpsa.github.io/jsgrid/
Other
28 stars 12 forks source link

jQuery UI Multiselect also requires localization files. #33

Closed himiklab closed 9 years ago

himiklab commented 9 years ago

https://github.com/michael/multiselect/tree/master/js/locale

flack commented 9 years ago

Seeing how this plugin is not maintained any longer, we should consider replacing it altogether (see #4)

OlegKi commented 9 years ago

I don't specify the problem as a bug, especially as a jqGrid bug. If one uses some plugin one should know it. Moreover everybody can include in his code the lines like

$.extend($.ui.multiselect.locale, {
    addAll:'Alle hinzufügen',
    removeAll:'Alle entfernen',
    itemsCount:'Einträge ausgewählt'
});

or just to use the code like

$.ui.multiselect.locale.addAll = "Alle hinzufügen";
$.ui.multiselect.locale.removeAll = "Alle entfernen";
$.ui.multiselect.locale.itemsCount = "Einträge ausgewählt";
meh-uk commented 9 years ago

That doesn't sound like a great workaround to be honest.

OlegKi commented 9 years ago

I don't want to suggest any workaround. I said just that one should include locale file of jQuery UI Multiselect it one want us it for different language. It's in the same way like one should include jQuery UI Datepicker locale (see here) if one need localized version of datepicker. I wrote the code example just to show that if one don't find an exiting locale for the required language one can easy write it yourself.

flack commented 9 years ago

Well, the thing is, if we distribute a plugin, we should make some effort to include all parts of it. It is just annoying for users if they have to hunt for some missing files. Also, you have to be aware that the plugin's API might have changed, so if you use the bundled multiselect JS, there is no guarantee that the i18n files from current github master will work with it.

So I'd say we should include them. But preferably after we switch to a newer release of the plugin