Closed meh-uk closed 9 years ago
Just making sure the issue we have discussed the most as being urgent is actually tracked.
Yes, having a ticket for this makes it a lot easier to handle (compared to random mails). The JS changes are currently synched up to (but not including) this one:
https://github.com/OlegKi/jqGrid/commit/3ab18e9476aa24362996bedab0928ea38723772b
Next steps:
datatype
autodetection)After, I would propose we wait for @OlegKi's documentation of his changes, because we need to keep our documentation in sync
This one :
https://github.com/OlegKi/jqGrid/commit/3ab18e9476aa24362996bedab0928ea38723772b
was a change i did, it was committed by me here :
https://github.com/openpsa/grid.js/commit/da6a917e8b4c4e31a49ecb0c829f957092352218
and here :
https://github.com/openpsa/grid.js/commit/10b1cd7f1c4bad2426f88accaa42f704186e5a11
So the Oleg's mentionned commit merge must be avoided.
Considering this one :
https://github.com/OlegKi/jqGrid/commit/aeb619246af73faa7a50678c7458a43df82554ff
There is no real conflict as autodetection doesn't care about it.
I'm starting this now, and it's heavy going, practically every commit conflicts, @OlegKi please can you stop making changes to your old branch and start making them from a new fork of this project? It isn't going to be possible for us to merge any more of your changes otherwise.
OK I've done the first ten or so commits and created pull #50. But it took ages to do even that small a number.
I have done another ten now, next one will be OlegKi/jqGrid@1fabe170059d320b0526b8666d6101b18beedfe9
P.S.: We still need to update the documentation for changed defaults & such
See the release notes file I created yesterday, it has the language file changes.
Yes, I saw. So we need to update the release notes and the options.md page
moving to : https://github.com/openpsa/grid.js/pull/50
Added #57 earlier, and now #60 so all of the JavaScript changes should now be merged.
What's this about ? :)