search

openpsa / jsgrid

Fork of last jqGrid version before license change
http://openpsa.github.io/jsgrid/
Other
28 stars 12 forks source link

Oleg gridjs #60

Closed meh-uk closed 9 years ago

meh-uk commented 9 years ago

Final lot - as before I've just undertaken the technical merge and haven't tested the changes.

meh-uk commented 9 years ago

I do agree that we shouldn't be changing either the public facing options or the html output without good reason, and perhaps we should revisit them.

I also think a Skype call would be a good idea, but to organize it will involve fitting around other people's personal commitments.

smartcorestudio commented 9 years ago

@OlegKi wrote: "... if we create common github repository on the "neutral" place"

What do you think about it?

OlegKi commented 9 years ago

@smartcorestudio : I wrote before that the current location is under https://github.com/openpsa/grid.js/ and OpenPSA is another open source project which exist since many years and which I don't know. What you think about using the place under the root http://microsoft.com/, http://apple.com or http://ibm.com?

I think that one could choose new name for the project and to use the location like https://github.com/newProjectName for example.

flack commented 9 years ago

@OlegKi If the name bothered you, couldn't you have said something when we made the repo? @smartcorestudio studio asked about the name on Dec 30 (the comment has since been deleted, since it was in Tony's repo), and I replied that we could still change it, but we should do it soon, before people link to the URL. Now we have a (basic) website up, people have made forks of the repo already, and @meh-uk has registered the project on bower. All of that will break if we move yet again.

I'm not saying that I am categorically against another move, but I don't see much benefits, either. The string "openpsa" appears nowhere in the source code or the documentation. Except in URLs of course, but then again, so does the string "github" (which is actually a commercial entity, not some open source project). And code ownership is defined by the licence headers (and the metadata of the individual git commits) anyways.

meh-uk commented 9 years ago

With regards to less we also discussed that and @OlegKi you raised no objections. Its quite clear that everyone else is in favour of using that rather than css - I guess we could go back on that decision, but that doesn't seem very collegiate.

Certainly in my experience css always turns into a giant mess where you have a massive file with inconsistent content, and less at least starts to address those issues. And actually I have been making some effort to port your css changes as well Oleg, and its clear from doing that that less shows up a number of issues with the jqGrid css.

flack commented 9 years ago

About LESS: Yes, you are right that the less files have no logic yet. that is because I just did a quick conversion when I originally set up the repository. But once everything settles, I plan to do a proper implementation of LESS, i.e. with the use of variables and all that. The advantage then is that users can easily customize the grid's look and feel. Long term, we might even have a customizer in the download builder like bootstrap has:

http://getbootstrap.com/customize/#less-variables

flack commented 9 years ago

About autodetection and the search toolbar changes: Please open separate tickets for each, then we can discuss the pros and cons. Having everything mixed up in one thread makes it kind of difficult to follow.

flack commented 9 years ago

@OlegKi: another addendum about the autodetection and search toolbar changes: If you had accepted the invitation I sent you, you would have been immediately notified by github about the pull requests. You could then have written your objections before the changes were merged, which would have avoided many complications. Being part of a "github team" doesn't cost you anything, and it doesn't mean that we all have to be best friends from now on, it just makes it easier to collaborate on a project

flack commented 9 years ago

Sorry for posting so many replies, but I still sport sentences in @OlegKi's long post that I have missed before :-)

For unit tests, I have integrated the groundwork in this commit:

https://github.com/openpsa/grid.js/commit/da9a04edc559040bc80e7f85711e53c92968b060

Tests are currently run automatically during grunt and grunt watch tasks. So basically, it's all there, someone just has to start writing some actual testcases. I'm planning to do that at some point, but I'd like to spend some more time fleshing out the website first. So this is a good chance to commit something that is guaranteed not to create merge conflicts :-)

smartcorestudio commented 9 years ago

I can confirm that @flack asked everybody about the name. Unfortunately that discussion was actually in the wrong place, and Tony deleted it :( I don't see anything bad in this name, but I think if someone have really principled disagreement against this name maybe it's not too late to change it

flack commented 9 years ago

Well, if we want to change it again, I propose theneutralzone as vendor name. Or thezone if you find the other one too long.

And if we're going for a rename, I would also like to change the repo name from grid.js to jsgrid. I picked the original name without giving it much thought (same as the vendor name, really), and after using it for a while, I find jsgrid both easier to type and to pronounce (plus, it hints a bit more explicitly to jqgrid).