search

openpsa / jsgrid

Fork of last jqGrid version before license change
http://openpsa.github.io/jsgrid/
Other
28 stars 12 forks source link

Fix bug in inline editing... #74

Closed bouks closed 9 years ago

bouks commented 9 years ago

that when manual calling of restoreRow function (in onEdit function), it doesn't restore action icons.

Also undo "little refactoring" and some personnal git problems :)

bouks commented 9 years ago

The real change is :

https://github.com/bouks/grid.js/commit/102b9c6f02b48f6d9fd04907c06efdce11e117e2

flack commented 9 years ago

@bouks about the personal git problems: You should try git pull --rebase or something similar, that usually gets rid of those merge commits. What I always do as a last resort is simply to delete the repo and simply clone it again :-)

bouks commented 9 years ago

@flack Thank's for the tip. I have to experiment more capacities of git. :)

flack commented 9 years ago

I have an alternative idea to fix this problem:

.ui-search-clear {
    position: absolute;
    right: 0;
}

This displays the clear icon on top of the input field, which looks nicer IMHO. We should probably also give the input field a padding-right so that the text doesn't overlay the icon.

BTW: I currently get an error when I click the clear button:

TypeError: $t.p.colModel[coli] is undefined
http://gridjs/grid.js-0.1.0.js
Line 6417

Do you see that, too?

flack commented 9 years ago

I have cherry-picked the inline editing fix now in https://github.com/openpsa/grid.js/commit/cb4e3bc8598f8b6f33530de89adf6b1dcc83f96e

Can you do a new pull request for the clear icon stuff? These clear/undo commits mess up the commit history and can cause problems with bisecting (I had those yesterday already with the pager problem, and they'll get worse when the number of merge commits/undos increases)