Aneslastic mass continuity cost function is wrong with tensorflow

openradar / PyDDA

Pythonic multiple doppler code based off the 3D variational technique

http://openradarscience.org/PyDDA

Other

91 stars 44 forks source link

Closed jm5791 closed 1 year ago

jm5791 commented 1 year ago

Hi devs,

Do we agree that the anelastic mass conservation is wrong when using the tensorflow implementation ? I mean that dwdz * anel_term should be dwdz + anel_term in https://github.com/openradar/PyDDA/blob/ba7e8a9a8e1712474a90c1e339969665b57716e2/pydda/cost_functions/_cost_functions_tensorflow.py#L534

Thanks

rcjackson commented 1 year ago

I'll put this fix in with #104! Thank you for pointing this out!

rcjackson commented 1 year ago

Fixed in #104! Closing!