updating ERA_Height calculation, forgot to divide the geopotential by 9.8

openradar / PyDDA

Pythonic multiple doppler code based off the 3D variational technique

http://openradarscience.org/PyDDA

Other

91 stars 44 forks source link

updating ERA_Height calculation, forgot to divide the geopotential by 9.8 #123

Closed syedhamidali closed 3 months ago

rcjackson commented 4 months ago

It looks like you did 3 PRs for the same fix. Since you've changed the geopotential height calculation, your output wind field will also change, so you would also need to change your unit test accordingly. I will close the other two PRs since they are redundant. Thanks for finding this bug @syedhamidali !

rcjackson commented 3 months ago

Failing tests unrelated to PR...merging.

syedhamidali commented 3 months ago

Thanks @rcjackson