search

openradar / PyDDA

Pythonic multiple doppler code based off the 3D variational technique
http://openradarscience.org/PyDDA
Other
91 stars 44 forks source link

It is seem that there is a bug in / pydda / cost functions / cost functions.py? it is should be corrected like this? #94

Closed zk19991208 closed 1 year ago

zk19991208 commented 1 year ago

微信图片_20230824165922 微信图片_20230824170020 The use of '_cost_functions_numpy. calculate_vertical_vorticity-gradient' should be identifed with its usage.

rcjackson commented 1 year ago

What error is being thrown when you try to use the vorticity constraint? Could you be more specific about what the syntax error is? It's difficult to see any error with the code the way this is presented.

zk19991208 commented 1 year ago

Thanks for the reply, Figure 2 _cost_functions_numpy.calculate_vertical_vorticity_cost doesn't have a keyword argument upper_bc but Figure 1 has one.It made my code wrong. mmexport1693077130077

rcjackson commented 1 year ago

I've fixed this with PR #95 !