openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
97 stars 17 forks source link

ENH: Add new examples using radar data on AWS s3 bucket #102

Closed aladinor closed 1 year ago

aladinor commented 1 year ago
mgrover1 commented 1 year ago

Thanks @aladinor - it looks like that did the trick!

mgrover1 commented 1 year ago

@aladinor - can you add boto3 to both the ci/unittests.yml and environment.yml files?

mgrover1 commented 1 year ago

I think the environment.yml is required too

mgrover1 commented 1 year ago

You'll need py-art too!

mgrover1 commented 1 year ago

Thanks for all you work here @aladinor !

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.08%. Comparing base (feab322) to head (42ba1bc). Report is 52 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ======================================= Coverage 88.08% 88.08% ======================================= Files 19 19 Lines 3297 3297 ======================================= Hits 2904 2904 Misses 393 393 ``` | [Flag](https://app.codecov.io/gh/openradar/xradar/pull/102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openradar/xradar/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | `88.08% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aladinor commented 1 year ago

Thanks @mgrover1 for your guidance!!!

kmuehlbauer commented 1 year ago

@aladinor Great work so far.

It's missing in the rendered docs. @mgrover1 Is this just on my side, or is there an additional link in the docs missing?

mgrover1 commented 1 year ago

It's missing... I can dig in and see if I can find the issue

kmuehlbauer commented 1 year ago

@aladinor @mgrover1 I'm not sure why the doc build fails now with these https/SSL errors while fetching data.

It doesn't look like it is caused by the changes in this PR. Also not sure if this might be related in any case https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/

Maybe it's just a spurious thing. Anyway, I'll catch up tomorrow.

kmuehlbauer commented 1 year ago

@aladinor This was a spurious thing. This is really looking a great example. Thanks for putting this together.

https://openradar-docs--102.org.readthedocs.build/projects/xradar/en/102/

I'm no native speaker either, but spotted some typos. Maybe you can have a final read on the rendered output and change what you feel necessary.

Again, this is a great example!

aladinor commented 1 year ago

@kmuehlbauer and @mgrover1, thanks for putting all the effort into this. I will work on typos.