openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
97 stars 17 forks source link

FIX: Correct DB_DBTE8/DB_DBZE8 and DB_DBTE16/DB_DBZE16 decoding #110

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

Update:

A bit more context here, we've just stumbled over these types in the wild. I've had a look into the docs/code and they are referenced as:

 DB_DBTE8         = 71,  /* Total Power Enhanced (via H+V or HV) (1 byte) */
 DB_DBTE16        = 72,  /* Total Power Enhanced (via H+V or HV) (2 byte) */
 DB_DBZE8         = 73,  /* Clutter Corrected Reflectivity Enhanced (1 byte) */
 DB_DBZE16        = 74,  /* Clutter Corrected Reflectivity Enhanced (2 byte) */

I've not added this to the moments mapping (attributes). So for now no attributes will be added. We'll gather more information before adding these attributes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #110 (3b182e1) into main (b8f9e27) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3b182e1 differs from pull request most recent head 1b9ca7e. Consider uploading reports for the commit 1b9ca7e to get more accurate results

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files          19       19           
  Lines        3297     3297           
=======================================
  Hits         2904     2904           
  Misses        393      393           
Flag Coverage Δ
unittests 88.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/iris.py 84.85% <ø> (ø)
mgrover1 commented 1 year ago

@kmuehlbauer let me know when this ready for review

kmuehlbauer commented 1 year ago

It's ready, as far as I'm concerned. :-)