openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

FIX: use datastore._group instead of variable["sweep_number"] #123

Closed kmuehlbauer closed 10 months ago

kmuehlbauer commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Merging #123 (2670a5e) into main (1e09e4f) will decrease coverage by 0.03%. Report is 2 commits behind head on main. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   88.18%   88.15%   -0.03%     
==========================================
  Files          19       19              
  Lines        3335     3336       +1     
==========================================
  Hits         2941     2941              
- Misses        394      395       +1     
Flag Coverage Δ
unittests 88.15% <85.71%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
xradar/io/backends/iris.py 84.77% <66.66%> (-0.09%) :arrow_down:
xradar/io/export/odim.py 96.77% <100.00%> (ø)
kmuehlbauer commented 10 months ago

@aladinor The approach here reads empty/corrupted sweep from your file and also displays a warning message.

aladinor commented 10 months ago

Thanks @kmuehlbauer for your help!