search

openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

FIX: always read nodata and undetect attributes from ODIM file #125

Closed egouden closed 9 months ago

egouden commented 9 months ago

The current behavior is to not read ODIM undetect and nodata attributes if the values are not transformed (i.e. the attribute gain is 1 and the attribute offset is 0). This can lead to a loss of information. I think these attributes should always be read.

kmuehlbauer commented 9 months ago

@egouden Sorry for the delay here. Could you please fix the linter error. Otherwise this looks OK to me.

codecov[bot] commented 9 months ago

Codecov Report

Merging #125 (ab2addd) into main (42d11c7) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files          19       19           
  Lines        3334     3334           
=======================================
  Hits         2941     2941           
  Misses        393      393
Flag Coverage Δ
unittests 88.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
xradar/io/backends/odim.py 84.98% <100.00%> (ø)
kmuehlbauer commented 9 months ago

Thanks @egouden!