openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
91 stars 17 forks source link

Data model + CfRadial1 Backend #13

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

First code porting from wradlib:

There is a first import from CfRadial1 into the DataTree.

kmuehlbauer commented 1 year ago

@mgrover1 Do we have a cfradial1 file somewhere? I have one inside wradlib-data repo. But that would be overkill. Shall we create a xradar-data repo where we host our testfiles?

mgrover1 commented 1 year ago

@kmuehlbauer - great question. I think a more general open-radar-data repo would be great. This way, we can share across repositories and such.

mgrover1 commented 1 year ago

I also do not see an issue in using one of the wradlib-data files, or one of the Py-ART ones used here

kmuehlbauer commented 1 year ago

I'll just fetch the one file from wradlib-data repo and see how it goes. For CI no problem since we need internet connection anyway.

kmuehlbauer commented 1 year ago

@mgrover1 I've added two tests, one for open_cfradial_datatree and one for xr.open_dataset. Added fixture to grab the cfradial1 file from wradlib-data repo.

This just works with the minimal required data. We would need to enhance this to also make optional attributes and variables available.

kmuehlbauer commented 1 year ago

@mgrover1 This is good to go from my end. There is still much to do, though.