openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

FIX: Fix handling of sweep_mode attribiutes #143

Closed mgrover1 closed 8 months ago

mgrover1 commented 8 months ago

We currently do not decode the sweep_mode attributes properly with the cfradial reader, and the common decoder used in the readers does not fully handle xr.DataArray data structures. This adds a fix, along with a test to ensure we are handling this properly

codecov[bot] commented 8 months ago

Codecov Report

Merging #143 (fed23f5) into main (815f504) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   88.32%   88.33%   +0.01%     
==========================================
  Files          20       20              
  Lines        3436     3439       +3     
==========================================
+ Hits         3035     3038       +3     
  Misses        401      401              
Flag Coverage Δ
unittests 88.33% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
xradar/io/backends/cfradial1.py 86.39% <100.00%> (ø)
xradar/io/backends/common.py 91.17% <100.00%> (+0.26%) :arrow_up: