openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
97 stars 17 forks source link

FIX: Add the proper elevation angle to fixed angle #162

Closed mgrover1 closed 6 months ago

mgrover1 commented 6 months ago

Ensure the elevation angle is unpacked into the fixed angle variable, giving a numerical value instead of the ordered dictionary

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.30%. Comparing base (56a9ca1) to head (f354054).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ======================================= Coverage 91.30% 91.30% ======================================= Files 21 21 Lines 3956 3956 ======================================= Hits 3612 3612 Misses 344 344 ``` | [Flag](https://app.codecov.io/gh/openradar/xradar/pull/162/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | Coverage Δ | | |---|---|---| | [notebooktests](https://app.codecov.io/gh/openradar/xradar/pull/162/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | `80.71% <100.00%> (ø)` | | | [unittests](https://app.codecov.io/gh/openradar/xradar/pull/162/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | `89.61% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgrover1 commented 6 months ago

@kmuehlbauer - I am not sure why it mentions we are taking a 1.7% hit in test coverage?

kmuehlbauer commented 6 months ago

@mgrover1 No, no idea. Let's just move on here. Maybe it's just intermittent?

kmuehlbauer commented 6 months ago

Seems ok now, no?

mgrover1 commented 6 months ago

yep! good to merge @kmuehlbauer ?

kmuehlbauer commented 6 months ago

Thanks @mgrover1 for the quick fix!