search

openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

ENH: Bring in extended list of supported message structures from MetPy for Level2 reader #163

Open jthielen opened 3 months ago

jthielen commented 3 months ago

As referenced in https://github.com/openradar/xradar/pull/158 and discussed with @mgrover1 in the MetPy telecon yesterday, there is still some relevant code in https://github.com/openradar/xradar/compare/main...jthielen:xradar:nexrad-level2 that may be helpful, namely that of a reconciled list of message structures combining those from both Py-ART's and MetPy's. Given that prior effort used MetPy's bespoke NamedStruct and BitField objects to handle this, there would likely be a quite a bit of refactoring needed (going either direction..modifying the reconciled lists to match the current xradar approach, or updating the xradar approach to use these MetPy-style objects). This issue can hopefully track this particular facet of the overall effort of https://github.com/openradar/xradar/issues/40.

kmuehlbauer commented 3 months ago

Thanks @jthielen for pushing this here.

I can have a look what would be necessary to incorporate things like BitField into the current structure.

I'm also interested to check if and how NamedStruct can be utilized for the current processing.