search

openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

adding radar parameters to xradar iris datatree #166

Closed aladinor closed 3 months ago

aladinor commented 3 months ago

adding radar parameters to xradar iris datatree

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mgrover1 commented 3 months ago

@kmuehlbauer - did you want to review as well? Otherwise, I think we can merge!

mgrover1 commented 3 months ago

wait one more thing - can you add this to the docs/history.md file?

kmuehlbauer commented 3 months ago

@mgrover1 @aladinor I do not want to block this improvement. :+1: to merge if you are happy with it. We can iterate later, if needed. 😊

mgrover1 commented 3 months ago

woo - sounds good! Yeah, @aladinor - please update that history.md file and we should be good to merge :)

mgrover1 commented 3 months ago

Thanks for adding yourself to the authors file as well!! 👍

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.32%. Comparing base (2225bfa) to head (4fba5e9).

Files Patch % Lines
xradar/io/backends/iris.py 91.30% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #166 +/- ## ========================================== - Coverage 91.33% 91.32% -0.02% ========================================== Files 21 21 Lines 3969 4010 +41 ========================================== + Hits 3625 3662 +37 - Misses 344 348 +4 ``` | [Flag](https://app.codecov.io/gh/openradar/xradar/pull/166/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | Coverage Δ | | |---|---|---| | [notebooktests](https://app.codecov.io/gh/openradar/xradar/pull/166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | `80.57% <91.30%> (+0.09%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/openradar/xradar/pull/166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar) | `89.65% <91.30%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openradar#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgrover1 commented 3 months ago

We can ignore the codecov test here - it is flagging the history file - let's merge!

aladinor commented 3 months ago

Thanks @mgrover1 and @kmuehlbauer for your help and time!