openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
91 stars 17 forks source link

ENH: Add georeference module, basic tests #28

Closed mgrover1 closed 1 year ago

mgrover1 commented 1 year ago

Add some georeference helper functions, first steps to georeferencing the xradar object

kmuehlbauer commented 1 year ago

Thanks @mgrover1 for setting this up. :+1:

Just some questions, comments and thoughts:

Basically in wradlib we are using the same equations derived Doviak. We might utilize the existing wradlib function which adds the x, y, z and groundrange coordinate DataArrays.

mgrover1 commented 1 year ago

Yeah - on second thought, I like that idea of operating at the dataset level instead of the numpy level. This is using the current functions/methods we have in Py-ART, but adapting it to work at the dataset level is a better approach.

I will make those changes, and ping you when it is ready for review.

kmuehlbauer commented 1 year ago

Ready to go, @mgrover1 ?

mgrover1 commented 1 year ago

Sure :)

kmuehlbauer commented 1 year ago

Thanks @mgrover1, this is going to be fun to add to the current examples.