Closed kmuehlbauer closed 1 year ago
Merging #49 (e3a7cb6) into main (2aab4dc) will decrease coverage by
0.20%
. The diff coverage is73.77%
.
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 85.61% 85.41% -0.21%
==========================================
Files 15 17 +2
Lines 3079 3119 +40
==========================================
+ Hits 2636 2664 +28
- Misses 443 455 +12
Flag | Coverage Δ | |
---|---|---|
unittests | 85.41% <73.77%> (-0.21%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
xradar/io/export/cfradial2.py | 34.78% <34.78%> (ø) |
|
xradar/model.py | 94.25% <95.00%> (+0.09%) |
:arrow_up: |
xradar/io/backends/cfradial1.py | 88.02% <100.00%> (+2.12%) |
:arrow_up: |
xradar/io/export/__init__.py | 100.00% <100.00%> (ø) |
|
xradar/io/export/odim.py | 95.04% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@kmuehlbauer I think we can go ahead and merge this
Yes, we can add anything I forgot in follow up PR's.
These kwargs are available for DataTree loading, as well as Dataset-loading.
to_cfradial2
export functionTodo: Add tests for the introduced functionality.
closes: #48
This PR also updates pre-commit hooks:- add nbstripout, to clean notebooks before committing- remove thedouble-quote-string-fixer
, as it contradicts with black-formatting- remove the skip-string-normalization from black-formatting- format with blackI can split this into two, if necessary. Need to make sure to do rebase-merge otherwise.This part moved to #50