openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
88 stars 17 forks source link

MIN: align rainbow open-api with CfRadial1/2 #58

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

needs to be rebased and go in after #57 is merged

codecov[bot] commented 1 year ago

Codecov Report

Merging #58 (86d0e2c) into main (8a0d7f8) will decrease coverage by 1.22%. The diff coverage is 56.52%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   84.51%   83.29%   -1.23%     
==========================================
  Files          17       17              
  Lines        3120     3118       -2     
==========================================
- Hits         2637     2597      -40     
- Misses        483      521      +38     
Flag Coverage Δ
unittests 83.29% <56.52%> (-1.23%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/odim.py 88.10% <33.33%> (+0.12%) :arrow_up:
xradar/io/backends/rainbow.py 82.76% <50.00%> (-0.05%) :arrow_down:
xradar/io/backends/gamic.py 85.03% <60.00%> (-1.58%) :arrow_down:
xradar/io/backends/common.py 64.33% <100.00%> (-24.24%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmuehlbauer commented 1 year ago

If there are not complains I'll get this in early next week latest.