openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
88 stars 17 forks source link

Add georeference accessor #60

Closed mgrover1 closed 1 year ago

mgrover1 commented 1 year ago

Add a georeference accessor which works with dataarrays, datasets, and datatrees.

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (e095877) into main (82a8fe4) will increase coverage by 0.14%. The diff coverage is 100.00%.

:exclamation: Current head e095877 differs from pull request most recent head 68ade47. Consider uploading reports for the commit 68ade47 to get more accurate results

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   83.29%   83.43%   +0.14%     
==========================================
  Files          17       17              
  Lines        3118     3146      +28     
==========================================
+ Hits         2597     2625      +28     
  Misses        521      521              
Flag Coverage Δ
unittests 83.43% <100.00%> (+0.14%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/accessors.py 68.18% <100.00%> (+29.05%) :arrow_up:
xradar/georeference/transforms.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mgrover1 commented 1 year ago

@kmuehlbauer when you get a chance, any feedback here would be greatly appreciated!

mgrover1 commented 1 year ago

Thanks for the comments and suggestions @kmuehlbauer - I added in those kwargs to the accessors + datatree transform

kmuehlbauer commented 1 year ago

@mgrover1 I'm sorry if the recent merges of my other two PR messed up rebase of your branch.

mgrover1 commented 1 year ago

@kmuehlbauer no worries!