openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
98 stars 17 forks source link

ENH: make Furuno reader read WRN110 scn data (format 103) #65

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

closes #59

codecov[bot] commented 1 year ago

Codecov Report

Merging #65 (adecb7c) into main (bb71414) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   84.83%   84.82%   -0.01%     
==========================================
  Files          18       18              
  Lines        3224     3223       -1     
==========================================
- Hits         2735     2734       -1     
  Misses        489      489              
Flag Coverage Δ
unittests 84.82% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/cfradial1.py 86.39% <ø> (ø)
xradar/io/backends/gamic.py 86.16% <ø> (ø)
xradar/io/backends/iris.py 79.00% <ø> (ø)
xradar/io/backends/odim.py 88.07% <ø> (ø)
xradar/io/backends/rainbow.py 82.45% <ø> (ø)
xradar/io/backends/furuno.py 89.42% <100.00%> (-0.04%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mgrover1 commented 1 year ago

@kmuehlbauer let me know when this is ready for review!

kmuehlbauer commented 1 year ago

@mgrover1 I'm fine with it now. We might want to rebase merge to have the CI changes in separate commits.

I've adapted to latest black defaults and removed Python=3.8 from the matrix (as xarray etc. are doing).

mgrover1 commented 1 year ago

@kmuehlbauer we could also have the version changes it in a separate PR?