openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
88 stars 17 forks source link

FIX: use of attributes #71

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #71 (dfe284b) into main (ed03a46) will increase coverage by 0.02%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   84.82%   84.84%   +0.02%     
==========================================
  Files          18       18              
  Lines        3223     3221       -2     
==========================================
- Hits         2734     2733       -1     
+ Misses        489      488       -1     
Flag Coverage Δ
unittests 84.84% <85.71%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/export/odim.py 95.79% <80.00%> (+0.75%) :arrow_up:
xradar/io/backends/furuno.py 89.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmuehlbauer commented 1 year ago

I'll need this to move forward with https://github.com/wradlib/wradlib/issues/614. @mgrover1, would be great if you could have a look here the next days. Thanks!

kmuehlbauer commented 1 year ago

Thanks Max for looking into this. I'm going to merge that and the other PR and push out a new release.