search

openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

FIX: ODIM_H5 backend inconsistencies #81

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

closes #80

fix several issues with the odim backend

codecov[bot] commented 1 year ago

Codecov Report

Merging #81 (24d8176) into main (23ff112) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 24d8176 differs from pull request most recent head 275f77a. Consider uploading reports for the commit 275f77a to get more accurate results

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files          18       18              
  Lines        3233     3229       -4     
==========================================
- Hits         2845     2842       -3     
+ Misses        388      387       -1
Flag Coverage Δ
unittests 88.01% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/odim.py 88.04% <100.00%> (-0.03%) :arrow_down:
xradar/io/export/odim.py 96.55% <100.00%> (+0.75%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmuehlbauer commented 1 year ago

@mgrover1 This and the other PR (#82) fix some inconsistencies I've stumbled over while working on depending wradlib on xradar.

Those who want to follow that endeavor: https://github.com/wradlib/wradlib/pull/617

I'm really happy how smooth the transition is working, let aside the little disturbances. There is not much missing in xradar and I can completely remove the compatibility layer.

kmuehlbauer commented 1 year ago

I'll go ahead an get this simple fix in, as well as the other PR's.