search

openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
97 stars 17 forks source link

FIX: furuno backend inconsistencies #82

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

closes #77

fixes several issues with the furuno backend

codecov[bot] commented 1 year ago

Codecov Report

Merging #82 (1bfe9d8) into main (a80389e) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   87.99%   87.98%   -0.02%     
==========================================
  Files          18       18              
  Lines        3233     3228       -5     
==========================================
- Hits         2845     2840       -5     
  Misses        388      388
Flag Coverage Δ
unittests 87.98% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/furuno.py 91.41% <100.00%> (-0.13%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmuehlbauer commented 1 year ago

I've checked with Alice from GFZ Potsdam. She provided a PPI sweep at -1deg to check the correct raw dtype of the elevation data. Thanks! We are now sure it's int16 instead uint16 as written in the manual.

kmuehlbauer commented 1 year ago

This issue was escalated to Furuno Japan. They already fixed the error in their manuals and updates will be distributed.