openradar / xradar

A tool to work in weather radar data in xarray
https://docs.openradarscience.org/projects/xradar
MIT License
85 stars 17 forks source link

FIX: check for dim0 if not given, only swap_dims if needed #94

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago
kmuehlbauer commented 1 year ago

I'm still thinking about a proper test for that.

codecov[bot] commented 1 year ago

Codecov Report

Merging #94 (18887cc) into main (010b104) will increase coverage by 0.41%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   87.75%   88.17%   +0.41%     
==========================================
  Files          19       19              
  Lines        3284     3289       +5     
==========================================
+ Hits         2882     2900      +18     
+ Misses        402      389      -13     
Flag Coverage Δ
unittests 88.17% <100.00%> (+0.41%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/export/cfradial2.py 86.95% <ø> (+52.17%) :arrow_up:
xradar/model.py 96.17% <100.00%> (+0.66%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmuehlbauer commented 1 year ago

Added cfradial2 roundtrip test and test first_dim in one go. Pulling this in, when CI finished and green.

kmuehlbauer commented 1 year ago

There has been an issue with ReadTheDocs. I've reported that at RTD and they had a look immediately as it seems. Thanks RTD!