openrails / test-launchpad-bugs

TEST repository for Launchpad bug migration exploration
0 stars 0 forks source link

[BUG 1404751] Defective shape causes hang (X2602, GM&O Springfield Switch, inspect) #1412

Closed twpol closed 2 years ago

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/bugs/1404751

Property Value
Reported by Jeffrey Kraus (krausyaoj)
Date reported Sun, 21 Dec 2014 23:02:21 GMT
Tags content, crash

Shape files use index values to refer to other parts of the shape file. If some of these values are out of range Train Simulator will function but display garbled graphics.

If a vertex index is out of range it will show a long line as shown at http://www.trainsim.com/vbts/showthread.php?320561-Corrupt-shape-files

Open Rails instead freezes in a loop but does not crash.

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/1

Property Value
Posted by Jeffrey Kraus (krausyaoj)
Date posted Sun, 21 Dec 2014 23:02:21 GMT
twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/2

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Mon, 22 Dec 2014 19:04:40 GMT

Could you please provide a download link to the vehicle OR freezes in an infinite loop with?

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/3

Property Value
Posted by Jeffrey Kraus (krausyaoj)
Date posted Mon, 22 Dec 2014 23:35:07 GMT

Download link: https://www.adrive.com/public/secxyj/GMO880B.zip

Fixing this bug will involve changes to the shape file reading code to check the validity of files. In particular, that indexes are within range.

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/4

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Tue, 23 Dec 2014 08:25:45 GMT

Thank you for the reference!

I still think writing a full-featured validator for MSTS .s format is not worth the effort. It must have been done by the MSTS developers, when they wrote their GMAX export plugin. This .s shape format now is not our future, it is our past. In the future we would rather implement a more recent and more widely supported format, for which the validator is also available.

And think of it: If the content creator does not care about his model displaying faulty, why would we care about it? At best, we can get around the infinite loop and write a warning line into the log file about e.g. index out of range. But in neither case we would disallow displaying any shape that otherwise don't crash the program.

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/5

Property Value
Posted by James Ross (twpol)
Date posted Sat, 03 Jan 2015 15:38:02 GMT

If you leave Open Rails hung for a minute or two, it should crash itself when it detects that it has hung. That log file would be more useful.

twpol commented 2 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/6

Property Value
Posted by Cédric GNIEWEK (sharpeserana)
Date posted Sat, 06 Nov 2021 07:45:50 GMT

Does the problem still happen with version 1.4?

twpol commented 2 years ago

Imported from https://bugs.launchpad.net/or/+bug/1404751/comments/7

Property Value
Posted by Launchpad Janitor (janitor)
Date posted Thu, 06 Jan 2022 04:17:30 GMT

[Expired for Open Rails because there has been no activity for 60 days.]