search

openrails / test-launchpad-bugs

TEST repository for Launchpad bug migration exploration
0 stars 0 forks source link

[BUG 1460147] Sound Variable1 for electrics varies from 0 to 1 instead of from 0 to 100 #1539

Closed twpol closed 8 years ago

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/bugs/1460147

Property Value
Reported by Carlo Santucci (carlosanit1)
Date reported Fri, 29 May 2015 16:26:46 GMT

Sound Variable1 for electrics, which is proportional to throttle, varies in OR from 0 to 1 instead of from 0 to 100 like in MSTS. I found this in 2007, see here: http://www.trainsim.com/vbts/showthread.php?243924-Does-anybody-know-about-the-variables-in-sms-files&p=1176391#post1176391 . For diesels it correctly varies from 0 to 1. In other words in MSTS sound variable 1 has the same range as variable 2 for electrics.

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1460147/comments/1

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Fri, 29 May 2015 16:34:20 GMT

Fixed in x.3131.

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1460147/comments/2

Property Value
Posted by James Ross (twpol)
Date posted Fri, 29 May 2015 21:01:11 GMT

The patch for this bug looks incorrect; you've added a line "inside" the if for electric locomotives, but as there's no braces around the body of the if the Variable2 line is no longer inside the if!

twpol commented 9 years ago

Imported from https://bugs.launchpad.net/or/+bug/1460147/comments/3

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Sat, 30 May 2015 05:24:39 GMT

Sorry James, fixed in x.3133.