openrails / test-launchpad-bugs

TEST repository for Launchpad bug migration exploration
0 stars 0 forks source link

[BUG 1177436] Dynamic pointer in two needle load meter not working #220

Closed twpol closed 9 years ago

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/bugs/1177436

Property Value
Reported by Mervyn Burse (mervyn)
Date reported Tue, 07 May 2013 15:57:22 GMT
Tags cabs

There are a number of MSTS cvf files that use two or more pointers to display ammeter information. Currently, none of those I have tested work properly in one way or another. The two pointer dial type ammeter has one pointer for "traction" which works properly but the "dynamic" indicator does not move although from the HUD it is clear that dynamic brakes do in fact work.

I have included one example of each type I have found so far.

There is also a problem with another type of display that uses pointers moving in a vertical scale of which the default series 2000 electric is an example. In this one the pointer should run bottom to top, but moves in the opposite direction.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/1

Property Value
Posted by Mervyn Burse (mervyn)
Date posted Tue, 07 May 2013 15:57:22 GMT
twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/2

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Sat, 06 Jul 2013 15:28:39 GMT

Where can the complete cab pack be downloaded?

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/3

Property Value
Posted by Mervyn Burse (mervyn)
Date posted Sat, 06 Jul 2013 20:44:45 GMT

trainsim.com http://www.trainsim.com/vbts/tslib.php?do=copyright&fid=26553 is a set by Charlie Sibaja. That gets you the type that moves across the top sector of the dial

http://www.trainsim.com/vbts/tslib.php?do=copyright&fid=19239 by Dwight Mitchell. That one uses the bottom sector of the dial. In both cases the two needles should move left to right.

For the vertical type of movement the default 2000 should be ok.

Mervyn


No virus found in this message. Checked by AVG - www.avg.com Version: 2012.0.2242 / Virus Database: 3204/5969 - Release Date: 07/06/13

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/4

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Sun, 14 Jul 2013 17:13:58 GMT

I believe I have found the bug, and attach here my proposed patch. At least the GenGP9 cab pointer moves with this patch. I wonder if the same correction should be inserted also for the tractive force load meter, even if usually it would not have effect, as the minimum value for that one is 0.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/5

Property Value
Posted by Mervyn Burse (mervyn)
Date posted Mon, 15 Jul 2013 16:33:50 GMT

As the tractive force needle is working properly at the moment, I would be inclined to leave that alone.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/6

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Sun, 21 Jul 2013 13:44:51 GMT

I attach here a reviewed patch, that intervenes only when the maximum range value of the cabview meter is equal to 0, leaving things unaltered in the other cases.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/7

Property Value
Posted by cjakeman (cjakeman)
Date posted Sun, 21 Jul 2013 15:19:35 GMT

Hi Carlo,

Am home once more (great weekend), so hope to commit your patch this evening.

Which loco cabs are you testing these changes with?

Chris

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/8

Property Value
Posted by cjakeman (cjakeman)
Date posted Sun, 21 Jul 2013 19:28:17 GMT

Hi Carlo,

Commit your patch as planned.

Which loco cabs are you testing these changes with?

Chris

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/9

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Sun, 21 Jul 2013 19:30:22 GMT

I have tested it with the GenGP9 cab (one of them mentioned by Mervyn) and with the standard D9 cab, to check that existing cabs still work.

twpol commented 10 years ago

Imported from https://bugs.launchpad.net/or/+bug/1177436/comments/10

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Sat, 18 Jan 2014 22:41:07 GMT

Fixed in X1685.