search

openrails / test-launchpad-bugs

TEST repository for Launchpad bug migration exploration
0 stars 0 forks source link

[BUG 1116247] Animated doors stop working after CTRL-E #646

Closed twpol closed 11 years ago

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/bugs/1116247

Property Value
Reported by Karsten Hindkaer (karsten-s)
Date reported Tue, 05 Feb 2013 13:27:29 GMT

When changing direction of the train (CTRL-E) the animated doors Q and SHIFT-Q stop working.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/1

Property Value
Posted by Karsten Hindkaer (karsten-s)
Date posted Tue, 05 Feb 2013 13:29:58 GMT

x1423

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/2

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Tue, 05 Feb 2013 16:09:25 GMT

In the Bernina freeware rolling stock the malfunction is different: at game start Q opens/closes the doors on both sides, while SHIFT-Q has no effect at all. After CTRL-E situation is unchanged: Q opens/closes doors on both sides, while SHIFT-Q has no effect at all.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/3

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Sun, 17 Feb 2013 15:05:12 GMT

The problem was the cab changing code hadn't took into account, that by changing cab the loco could also be changed. So the calling of SetCommandReceivers() didn't set the receiver to the correct loco.

I submit a patch for this problem. Developers, could you please review it and commit if it is correct?

P.s.: Carlo, your problem is unrelated to this. You saw no change after changing cab, because this bug only affects trains with the rear and front cab lies in different wagon in the consist. Your problem is with the names of the anim nodes in .s file. All occurences (2 of each) of strings at left should be renamed to string at right: DEUR_BINNEKANT05 DOOR_BINNEKANT05 DEUR_BINNEKANT06 DOOR_BINNEKANT06 DEUR_BINNEKANT07 DOOR_BINNEKANT07 DEUR_BINNEKANT08 DOOR_BINNEKANT08

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/4

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Sun, 17 Feb 2013 15:12:31 GMT

BTW the bug is a duplication of Bug #1101242 , please also mark that one as "Fix committed", when marking this one.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/5

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Sun, 17 Feb 2013 19:07:45 GMT

An addition: While this simple patch works and correct, something not 100% correct is going on. Seems SetCommandReceivers() did set the receiver for the correct loco, but for some reason that doesn't matter for the program. What matters is the correct setting of PlayerLocomotiveViewer variable, that my patch corrected.

But it is a strange behavior, I have a feeling this shouldn't be like this. A bit more investigation wouldn't hurt, by someone having deep understanding of this command receiver.

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/6

Property Value
Posted by cjakeman (cjakeman)
Date posted Mon, 18 Feb 2013 07:49:17 GMT

Hi Peter,

Thanks for digging into this and offering a patch.

SetCommandReceivers() is one of mine so I'll look into the "strange behaviour".

Best wishes,

Chris

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/7

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Mon, 18 Feb 2013 08:27:57 GMT

Thank you Chris. If you don't have a consist at your hands to test on, this might be a good one: http://users.atw.hu/flirt-msts/e107_files/downloads/H-Start_5341-004_10_v2.zip

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/8

Property Value
Posted by Carlo Santucci (carlosanit1)
Date posted Thu, 28 Feb 2013 08:28:33 GMT

Hi Peter, thank you very much for your analysis on the Bernina doors. However I must say that I have no problems running the same rolling stock under MSTS.

Carlo

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/9

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Thu, 28 Feb 2013 11:31:08 GMT

The thanks shall go to James, he was the one eventually fixed those issues reliably. (But this is unrelated to this specific bug report we are chatting in. :-) )

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/10

Property Value
Posted by Peter Gulyas (pzgulyas)
Date posted Thu, 28 Feb 2013 11:35:39 GMT

Carlo, see Bug #1127500

twpol commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1116247/comments/11

Property Value
Posted by cjakeman (cjakeman)
Date posted Thu, 28 Feb 2013 22:16:45 GMT

Thanks Karsten for reporting this bug and Peter for providing that useful consist. Fix committed in v1464.