search

openrasta / openrasta-castle-windsor

Integrates Castle Windsor with OpenRasta.
1 stars 6 forks source link

Adding some tests for http listener with windsor #7

Closed nmosafi closed 9 years ago

nmosafi commented 9 years ago

These tests demonstrate how to configure Windsor to make HttpListenerHost work. There is one ignored test which fails - if the handler takes a dependency on IResponse.

nmosafi commented 9 years ago

As a workaround it seems possible to take a dependency on ICommunicationContext and pull out the Response property, rather than taking a dependency on IReponse

serialseb commented 9 years ago

Sorry just getting around to this, it only popped up in my notifications now, go figure. What do we want to do with this?

holytshirt commented 9 years ago

Looks like more test coverage, so should be good. I'm happy with this

holytshirt commented 9 years ago

:+1:

nmosafi commented 9 years ago

Just saw this, note this test is designed to show a bug and hence there is a failing test which is Ignored

Thanks

On 22 September 2015 at 16:04, Toby Henderson notifications@github.com wrote:

Merged #7 https://github.com/openrasta/openrasta-castle-windsor/pull/7.

— Reply to this email directly or view it on GitHub https://github.com/openrasta/openrasta-castle-windsor/pull/7#event-415956230 .

holytshirt commented 9 years ago

@nmosafi fixed your ignored test

nmosafi commented 9 years ago

Ahh cool! Why is it that we have to register those http related objects as null when we create the container?

On 22 September 2015 at 16:34, Toby Henderson notifications@github.com wrote:

@nmosafi https://github.com/nmosafi fixed your ignored test

— Reply to this email directly or view it on GitHub https://github.com/openrasta/openrasta-castle-windsor/pull/7#issuecomment-142325974 .

holytshirt commented 9 years ago

I was due to changes in the newer versions of Windsor and us still doing things in a very old way. The whole integration needs a rewrite, I tried a while back but could not get all tests passing and ran out of time.

On Tue, Sep 22, 2015 at 4:49 PM, Neil Mosafi notifications@github.com wrote:

Ahh cool! Why is it that we have to register those http related objects as null when we create the container?

On 22 September 2015 at 16:34, Toby Henderson notifications@github.com wrote:

@nmosafi https://github.com/nmosafi fixed your ignored test

— Reply to this email directly or view it on GitHub < https://github.com/openrasta/openrasta-castle-windsor/pull/7#issuecomment-142325974

.

— Reply to this email directly or view it on GitHub https://github.com/openrasta/openrasta-castle-windsor/pull/7#issuecomment-142330483 .