Remove classed func execution on empty data

openrca / orca-ui

Web UI for OpenRCA

https://openrca.io

Apache License 2.0

33 stars 4 forks source link

Remove classed func execution on empty data #136

Closed k-jano closed 3 years ago

k-jano commented 3 years ago

This PR resolves bug described in #134 and #135. classed() func should not be executed on empty data.

bzurkowski commented 3 years ago

@k-jano I checked in my testbed and the issue is only partially gone. There is no error when only alert type is selected. However, no objects are present in the graph at all:

Note that there are 13 alerts reported in the system.

bzurkowski commented 3 years ago

I guess that is the expected behavior since alerts without a source are not displayed in the graph. @k-jano Please, confirm 😉

k-jano commented 3 years ago

@bzurkowski Exactly, this is expected behaviour, because we describe alert namespace based on the namespace of a source.

However this is an issue to solve. I think that you are right, there should be possibility to display only alert objects in the graph. I suggest to deliver this solution in separate PR, because:

it is not the problem explicit pointed in corresponding issues
there is a need to changing the graph behaviour, e.g. specifying alerts namespace based on full payload, not only rendered one

bzurkowski commented 3 years ago

Fully agree. I reported an issue to track the proposed enhancement (#139). Let's merge this PR!