openreferral / ServiceNet

7 stars 6 forks source link

Create data entry Page for new record creation #954

Closed johnhbenetech closed 4 years ago

johnhbenetech commented 4 years ago

When a user clicks the 'add a record' option, they will enter into a workflow to collect a reduced set of fields from our full data standard. It will walk them through first adding org details, then locations, then service information.

One new thing is the ability to attach services to locations. We can discuss this in more detail, but refer to: https://openreferral.readthedocs.io/en/latest/hsds/reference/#service_at_location

The entered data will be saved to a new record with the logged in user set as owner.

image

image

image

kkaczmarczyk commented 4 years ago

@johnhbenetech a few questions popped up

  1. Are there any mockups/guidelines/suggestions about how this screen may look on the mobile screens/resolutions? Or should it be more-or-less similar?
  2. What would Service Type list look like? From where we should source it? Per devs: currently it is just saved as string in db.
  3. Are the locations from 3rd step pulled from 2nd step? Ie. firstly user defines the locations of his organizations and then assigns services to organization's locations?
johnhbenetech commented 4 years ago
  1. I'll work on that now. It should be largely the same - the only thing im considering is if the go back/add/finished options would move to a static bottom nav bar. I'm trying to go for a vaguely material design approach.

  2. It would be fed from the 'taxonomy' entities. All "Service Provider" records will have the same taxonomy options. I'll provide the list shortly, but it will be ~20 options and would be 1 to many.

  3. Yes. This is what I'm currently thinking. It would be a multiselect dropdown listing like: "Address 1, City" for each location entered on previous step.

johnhbenetech commented 4 years ago

image

jkondrat commented 4 years ago

Hi @johnhbenetech, I have a few questions regarding the inputs:

  1. Where should we pull the service types from?
  2. What should we put in the 'CA' select?
  3. Which location field should be used as a label in the 'Where Is This Service Offered' select?
  4. Once another location or service is added, should it be possible to remove it?
johnhbenetech commented 4 years ago
  1. We should make a new taxonomy set for the "Service Provider" system account. For now it can copy the ShelterTech values. This should be a mutiselect that hopefully has the type to filter interaction we currently have on our taxonomy filter.

  2. This should be the 50 US state abbreviations. These are the USPS column here: https://en.wikipedia.org/wiki/List_of_U.S._state_abbreviations but dont include the blue highlighted rows for the territories. It should always be prepopulated to CA for california since that's where we expect 99% of the resources to be located.

  3. lets do concatenated "Address 1, Address 2, City"

  4. That's a good point. I can work on a mockup, but we can put a grey remove button at the same level as the add button. remove left aligned, add right aligned.

For the 1st record, hitting that button will just clear all values but still display the blank form. For any latter record it will remove that record but keep the remaining records in place

bognasoldev89 commented 4 years ago

Verified on staging env

Verified cases

  1. I was able to create a new Organization with needed information

  2. Validation is correct 954 2

  3. "Remove" button removes the last entry on Locations and Services pages. Should user have a possibility to choose which entry is to remove? @johnhbenetech what do you think? 954 1

  4. I created 2 Locations, added the second one to created Service, went back, removed chosen Location. Should this be removed? 954 4

  5. I tried to save the Organization from point 4 and got "Internal server error". I removed this empty element and tried to save the Organization and got "Bad request". I had to add existing Location to save the Organization, but this field is not validated. 954 5

  6. Locations are counted from 1 on Locations page and from 0 on Services page.

  7. Mobile UI issues: 7.1. Fields are not placed even (the first one is visible on a browser as well): 954 6 954 7

7.2. "Add another" button is not placed even: 954 7 954 8

7.3. Is it possible to make tabs display title in the same way? 954 9

UI for browser is proof for zooming in and out.

Used resolutions:

bognasoldev89 commented 4 years ago

I rechecked this issue and all of the raised issues are fixed but one:

Locations are counted from 1 on Locations page and from 0 on Services page.

locations counting

@jkondrat can you look into that?

bognasoldev89 commented 4 years ago

Tested with success

Verified on staging env Used resolutions:

Verified cases

Summary All of the issues are resolved, this feature works correctly and elements look as expected.

Attachment Fixed Locations count on Services page: locations counting 2