openreferral / api-specification

This is the working repository for Open Referral's Human Services Data API protocols.
https://openreferral.readthedocs.io/en/latest/hsda/
Other
29 stars 13 forks source link

Duplicate operation descriptions in Open API definition #64

Closed xrysanthos closed 6 years ago

xrysanthos commented 6 years ago

There are many operations that have exactly the same description semantics even though they belong to different contexts. e.g.

all have the description Get Contacts.

Although this can be easily overlooked as it cannot be considered as a technical issue it really is a game changer when it comes to consumers that depend heavily on the semantics of the API.

image

I would be happy to assist with any metadata dedup / enrichment tasks.

kinlane commented 6 years ago

Thanks for pointing out. Known issue. With limited resources on staff, and this being a (mostly) unpaid role for myself, I have to pick my battles. I depend on the community to step in.

Feel free to edit the OpenAPI and submit pull requests for changes. My recommendation is that when you begin you drop a message here. To prevent any parallel work that is going on within the development from conflicting. Then when you submit pull request, it can be synced with dev efficiently.

Thanks for this.

xrysanthos commented 6 years ago

So, should I assume that the definition is crafted by hand and not auto-generated through code annotations? Just double-checking.

kinlane commented 6 years ago

It is the central truth. Not autogenerated. Managed on Github. All code, tests, docs, are generated from it. Correct.

xrysanthos commented 6 years ago

That's all I wanted to hear! Thanks Kin.

xrysanthos commented 6 years ago

@kinlane Just created a PR for this. Let me know if you need any clarifications.