search

openreferral / specification

The Human Services Data Specification - a data exchange format developed by the Open Referral Initiative
https://openreferral.org
Other
117 stars 49 forks source link

Make "license" field object rather than array #102

Closed danfowler closed 7 years ago

danfowler commented 7 years ago

On https://github.com/openreferral/specification/blob/master/datapackage.json#L4

Currently, license is defined to as a string or object, not an array:

license is an object OR string. The value of the string version SHOULD be an Open Definition license ID (preferably one that is Open Definition approved.

http://specs.frictionlessdata.io/data-packages/#strongly-recommended-fields

Note: options for adding additional licenses to be defined: https://github.com/frictionlessdata/specs/issues/236

robredpath commented 7 years ago

@danfowler 3cfaf4c

That branch should get merged in within a few days, so I'm working on all these tweaks on it for now to avoid merge hell later

NeilMcKLogic commented 7 years ago

There's another item here suggesting the License, along with a few other items, be collapsed to be just fields in their parent object and I support doing so.

robredpath commented 7 years ago

Thanks @NeilMcKechnie . At the moment we're trying to make the smallest possible changes to the schema that will bring it back into line with the Frictionless Data spec and allow us to auto-generate docs from the schema.

I'll make sure that this issue stays open for that recommendation to be considered for the next actual upgrade, as it's worth discussing.

timgdavies commented 7 years ago

I think there were two things being discussed here:

As this issue was about the former, and I think we were keeping it open for the later (and the later is covered in #78) I'm closing this.