openreferral / specification

The Human Services Data Specification - a data exchange format developed by the Open Referral Initiative
https://openreferral.org
Other
117 stars 49 forks source link

Docs: Previous version docs pages have broken link to latest version #448

Closed pimlottc closed 8 months ago

pimlottc commented 1 year ago

On the docs pages for older revisions of the specs, there's a notice alert that tells the user there's a newer version of the spec, which is great. Unfortunately, the link to the latest version is broken on most (all?) pages.

Note You are not reading the most recent version of this documentation. v3.0 is the latest version available.

Examples:

This applies equally to v2.0.1 pages as well.

pimlottc commented 1 year ago

This is particularly irksome since many of these older pages are the top hits on Google: #449

mrshll1001 commented 1 year ago

Thanks for flagging this!

The underlying issue is that the pages no longer have a direct correspondence to pages on the latest version of the docs. Unfortunately, this issue also persists when using the RTD's built-in sidebar :-/

I think a fair step is editing the notices on each the 2.0 and 2.0.1 branches to do the following:

This will always guarantee to dump them out at the latest version of the docs, but the tradeoff is that they'll then need to locate and navigate to specific content from there.

mrshll1001 commented 1 year ago

I have investigated this and it appears that it may be something we have to live with, at least in the medium term.

This banner is injected by RTD because we've enabled it in the settings for the project (docs). It's a binary option, so either we get it or we don't.

Thankfully, the 3.0 is also auto-generated, and will update with each new "latest" version number.

The little control we do have over the banner is that we can control where on the page it is injected, but not the comment or the target of the link. It's basically working as designed, because the "404" link page actually states the following message:

Documentation changes over time and pages are moved around. You can try to navigate to the index page of the project and use its navigation, or search for a similar page.

The only way we could approach this would be to use some client-side scripting to grab the anchor element for the link and change the href property. Alternatively, we could migrate the sphinx project away from readthedocs and play with the plugin which generates the message. This would involve setting up some complex parallel infrastructure just for this issue, though.

I think either of these would be overkill for something like this, considering it is intended behaviour for Read the docs.

I'm going to leave this issue open for now just in case someone has particularly strong feelings to the contrary, but I really think there's nothing actionable we can do given the limitations of the platform. The underlying issue, as stated, is that we've evolved the structure of the documentation pages. Thankfully, this has been done as part of a MAJOR version change from 2.0.1 to 3.0, so backwards compatibility should not be expected.

dan-odsc commented 11 months ago

@greggish Are you happy for this to be closed?

greggish commented 11 months ago

So we did take these two actions?

If so, seems fine to me given the alternatives...

mrshll1001 commented 10 months ago

@greggish as per previous comment:

Ultimately, it's functioning as intended, regardless of how jarring we find it :-/

I propose we should close this issue, and open a new one to frame the discussion of whether this issue is worth migrating our documentation builds to some privately hosted sphinx docs which we have control over.

mrshll1001 commented 8 months ago

Closed in favour of wider discussion in #490