openresearchcalendar / openresearchcalendar.github.io

Documentation & Code for the community tool: 'Open Research Calendar'
https://openresearchcalendar.org
GNU General Public License v3.0
19 stars 8 forks source link

[BUG] Google Script silently fails if end date(/time) before start date(/time) #34

Closed b-kennedy0 closed 3 years ago

b-kennedy0 commented 3 years ago

Describe the bug The google script to push events to calendar fails if the end date/time of the event is before the start date/time. This can happen when the person completing the new event form fills it out incorrectly.

To Reproduce Steps to reproduce the behaviour: Add new event in the form, setting end date/time before the start date/time

Expected behaviour It would be good if the new event form validated the response of end date before allowing the person to submit.

b-kennedy0 commented 3 years ago

Solution might be to implement a version of this: https://formfacade.com/website/google-forms-date-validations-allow-submit-seven-days-in-advance.html - just to check that the end date/time is not before the start date/time

However, the time effort involved to implement this, simply to prevent user input error, doesn't seem worth it right now.

Will keep this issue open and if there are further instances of user input error, we can consider embedding our new event form into FormFacade. Limitation would be 100 responses per month on their free plan (https://formfacade.com/website/pricing.html) which I don't think we exceed anyway. The edit feature in FormFacade might be a paid feature 😢

b-kennedy0 commented 3 years ago

Corrected with #38 #40 as Tripetto will validate that End date is not before Start date. Also validates that Start date is in the future to form submission (further reducing input errors).

image