openresearchcalendar / openresearchcalendar.github.io

Documentation & Code for the community tool: 'Open Research Calendar'
https://openresearchcalendar.org
GNU General Public License v3.0
18 stars 7 forks source link

[Bug]: Multiday events that span two months don't show in the newsletter #86

Closed gavinscode closed 1 year ago

gavinscode commented 1 year ago

Is there an existing issue for this?

Contact Details

gavin.taylor.01@gmail.com

What happened? / Describe the bug

The February 2023 newsletter didn't show two multiday events that started in February but finished in March. These were the:

Steps To Reproduce

No response

What device are you seeing the problem on?

No response

Environment (if relevant)

Gmail inbox in Chrome

Relevant log output

No response

Anything else?

No response

Code of Conduct

b-kennedy0 commented 1 year ago

Hello @gavinscode - Thank you for reporting this bug. It looks like it might be related to how our code searches for relevant events. I'll take a look and see if we can modify it.

b-kennedy0 commented 1 year ago

So some good news and some bad news:

Good news: The code is already set up to handle events that start in one month and end in the next. We can see from the records that the 'Responsible Animal Research Course' was submitted to the ORC on 02/02/2023 10:11:57. As the Newsletter conducts its search on the 1st day of the month at 9 am (Europe/London), that event was not in the database at the time of the search.

Bad news: The event 'Open Research Week 2023' was submitted to the ORC on 7/12/2022 13:53:10 so it should have made it into the newsletter. It seems that at some point between Dec 29th 2022 and Dec 31st 2022, the event was manually removed from our database (it looks like it was human error!). So the event exists on the calendar but not in our database. When the newsletter process ran, it searched our database and not the calendar, therefore, it did not find that event.

Thanks again for raising the bug report. It helps us to find errors like this and prevent them in the future.