remove duplicated ARG RESTY_IMG_TAG and RESTY_IMAGE_BASE.

openresty / docker-openresty

Docker tooling for OpenResty

https://hub.docker.com/r/openresty/openresty

BSD 2-Clause "Simplified" License

942 stars 529 forks source link

remove duplicated ARG RESTY_IMG_TAG and RESTY_IMAGE_BASE. #218

Closed zhuizhuhaomeng closed 1 year ago

neomantra commented 1 year ago

@zhuizhuhaomeng Thank you for your contribution -- I appreciate that you fixed all the files.

However, those duplicate ARG statements must be there after the FROM, otherwise the values are not carried through the rest of the file; the LABEL statements below need them.

Here's an example where I had to fix an issue because of that:

https://github.com/openresty/docker-openresty/issues/179
https://github.com/openresty/docker-openresty/commit/0006a337290e9fb66fbc6e36e87e23ad91c5d978

neomantra commented 1 year ago

As I'm testing other image label issues, I thought of this PR. I am not 100% sure of my comment. Also, I linked the wrong issue and I cannot find the original issue right now (years ago). But, this is the relevant Dockerfile documentation regarding FROM and ARG. Still investigating but I may re-open this.