search

openresty / docker-openresty

Docker tooling for OpenResty
https://hub.docker.com/r/openresty/openresty
BSD 2-Clause "Simplified" License
935 stars 525 forks source link

Point for command injection after openresty download before configure #219

Closed pgibson1-godaddy closed 1 year ago

pgibson1-godaddy commented 1 year ago

Is it possible to get a place to inject custom commands after the openresty download has happened but before the configure happens?

For example it would be ideal right after this line https://github.com/openresty/docker-openresty/blob/1.21.4.1-4/focal/Dockerfile#L146

It could be called something like RESTY_EVAL_POST_DOWNLOAD_PRE_CONFIGURE and it would let us run any patches or changes we want to make against the openresty source before compilation.

pgibson1-godaddy commented 1 year ago

I added a PR which I believe would do this as well #220

neomantra commented 1 year ago

Thanks for the report and the PR. This makes sense and is a straightforward change, so I can merge this later today.
I wish that the RESTY_EVAL_PRE_CONFIGURE phase was named differently once upon a time, as it's more appropriate for this, but we are stuck :)

If you wanna be in AUTHORS.md, just let me know a name / email (both optional).

pgibson1-godaddy commented 1 year ago

@neomantra Awesome - thank you, it will make our build much less hacky!

I don't need any credit in AUTHORS.md - thanks for your work. 👍

pgibson1-godaddy commented 1 year ago

@neomantra is it possible to make a 1.21.4.1-5 tag from master now? Thanks in advance.

neomantra commented 1 year ago

Oh I think GitHub auto-closed that -- still working on the release. But that's what I'm doing.

neomantra commented 1 year ago

That is tagged in the repo as 1.21.4.1-5 and building now. So you can pull GitHub as a base for your image build process. The Docker images will be ready in a bit.

neomantra commented 1 year ago

OK, that's out, thanks again.