Open jakubgs opened 2 months ago
I have attempted to mitigate this issue by adding echo_sleep 0.001
and echo_blocking_sleep 0.001
in order to force the body to be loaded, and it does appear to slightly decrease the instances of missing body in Webhook request.
I'm actually a bit confused as to what's the correct way of doing this. I see at least 6 options:
$request_body
with -b
for echo_subrequest_async
.$request_body
with -b
for echo_subrequest_async
with echo_read_request_body
.$request_body_file
with -f
for echo_subrequest_async
.$request_body_file
with -f
for echo_subrequest_async
with echo_read_request_body
.$echo_request_body
with -b
for echo_subrequest_async
.$echo_request_body
with -b
for echo_subrequest_async
with echo_read_request_body
.I'm sure there's more combinations. No idea which is correct. Seem to me like none work correctly.
I'm using the
echo
modules to send the same GitHub webhook request to two backends that needs to receive it. I spit them usingecho_subrequest_async
, but when I do there is no request body. I have tried using both-b $request_body
and-f $request_body_file
with the same effect:When using
-f $request_body_file
I managed to catch this in Nginx errors:Which indicates that the request body is indeed missing, but as far as I know it is not, since GitHub does send it.
This suggests a bug in the
echo
module.