should we make build.sh more common ?

openresty / echo-nginx-module

An Nginx module for bringing the power of "echo", "sleep", "time" and more to Nginx's config file

http://wiki.nginx.org/NginxHttpEchoModule

BSD 2-Clause "Simplified" License

1.17k stars 255 forks source link

should we make build.sh more common ? #46

Closed chipitsine closed 8 years ago

chipitsine commented 8 years ago

module echo-nginx-module usually added to stock nginx. however, build.sh compiles nginx without many common modules, i.e. --without-http_autoindex_module, --without-http_auth_basic_module, ....

I suggest to remove those "without"s in order to make test closer to what people usually do with nginx.

agentzh commented 8 years ago

@chipitsine Those options are important since we want to ensure that ngx_echo does not accidentally depend on any standard nginx modules that can be disabled. See pull request #42 for such a real-world example issue.

chipitsine commented 8 years ago

ok, it does make sense to test that way