search

openresty / headers-more-nginx-module

Set, add, and clear arbitrary output headers in NGINX http servers
1.65k stars 221 forks source link

Add headers if not set #65

Open detailyang opened 8 years ago

detailyang commented 8 years ago

Hello. This PR is about the issue #60 for @SamMousa . It would add header if not present the specified header. new option (-i) usage as the following:

 # add input header X-Foo *only* if it `X-Foo` doesnt exist
 more_set_input_headers -i 'X-Foo: howdy';

 # add output header X-Foo *only* if it `X-Foo` doesnt exist
 more_set_headers -i 'X-Foo: howdy';

@agentzh please review this PR :grin:

agentzh commented 8 years ago

@detailyang Please use the ngx-releng tool to check the coding style and other issues in your changes.

Also, please use the reindex tool to re-format your .t files.

agentzh commented 8 years ago

@detailyang Thanks for the contribution! Please take care of the issues pointed out by my comments above. Thanks!

detailyang commented 8 years ago

@agentzh This time i check the code style pointed out by you comments above carefully. Please review again 😁

Thanks!

aleksandrs-ledovskis commented 6 years ago

@agentzh / @detailyang

Is there any external help needed to bring this PR to completion?

Fudoshiki commented 6 years ago

what status?

lmm-git commented 4 years ago

What's the current status on this PR?

ghost commented 4 years ago

@agentzh What's the current status on this PR?

jiricerhan commented 3 years ago

Any progress there? I could really use this feature.

janreges commented 3 years ago

+1 ... it will be very helpful for us.