Closed ArchangelSDY closed 5 years ago
@doujiang24 Will you have a look at this? Thanks.
@doujiang24 Sure, updated.
@ArchangelSDY Thanks a lot :)
@doujiang24 Could you merge this PR and tag a new release so that we can pick this change in downstream projects?
@ArchangelSDY
merged & added a new release tag: v0.02rc5
, thanks for your PR :)
What's the impact of this bug? As long as a user you aren't relying on nodes to be in sync (covered at https://github.com/openresty/lua-resty-balancer/pull/25/files#diff-cad7d8fbdf9d2fb89f5ee95f0b73dff7R338), there should not be any issue, right?
That's right as long as you don't need to read self.nodes
. I've added a comment in https://github.com/kubernetes/ingress-nginx/pull/3809#issuecomment-467036731 .
newnodes
should be assigned toself.nodes
rather thanself.newnodes
.