openresty / lua-resty-core

New FFI-based API for lua-nginx-module
810 stars 273 forks source link

why the lua version number is commented out in Makefile #449

Closed lynch1981 closed 10 months ago

lynch1981 commented 11 months ago

Can someone explain why the lua version number is commented out in Makefile? I think it would be better if we keep it

OPENRESTY_PREFIX=/usr/local/openresty

LUA_VERSION := 5.1

PREFIX ?= /usr/local LUA_INCLUDE_DIR ?= $(PREFIX)/include LUA_LIB_DIR ?= $(PREFIX)/lib/lua/$(LUA_VERSION) @@ -12,9 +13,11 @@ all: ;

zhuizhuhaomeng commented 11 months ago

We don't know the reason. It was changed in commit dbc9b6fd.

lynch1981 commented 11 months ago

I saw someone reporting this failure, keeping LUA_VERSION would make it easier for them to install ngx_lua. nginx: [alert] failed to load the 'resty.core' module

zhuizhuhaomeng commented 11 months ago

As long as ci stays through, we can uncomment it.

zhuizhuhaomeng commented 10 months ago

merged with small modification, please check the lastest master code.