search

openresty / lua-resty-upstream-healthcheck

Health Checker for Nginx Upstream Servers in Pure Lua
521 stars 134 forks source link

Set a different upstream manager module #11

Closed Tieske closed 8 years ago

Tieske commented 8 years ago

The module currently relies on the ngx.upstream module for managing the upstreams.

Unfortunately we cannot use that module for our usecase. See discussion here

Would you accept a PR to set the module explicitly, making it configurable? so I won't have to fork the code.

If so, should it be a setting on module level (in an upvalue, shared by all checkers spawned), or a setting per spawned checker. Imho the latter, but please share your thoughts.

agentzh commented 8 years ago

@Tieske That makes sense. I prefer passing the concrete upstream object via an argument option too.

Tieske commented 8 years ago

Ok, Thx for the heads up. I'll work on a PR. Will you be merging #10? so I can base the new PR on that (otherwise it will surely deliver some conflicts)

Tieske commented 8 years ago

closing this in favor of #12