Closed Tieske closed 5 years ago
@agentzh any update? this actually is a bug, see #16
ping @agentzh @doujiang24
@doujiang24 I've got too many other things going on right now, and we're not using this module any more
@thibaultcha Will you take care of this one please?
Closed in favor of #59 which comes with a test case and additional fixes. Thanks @Tieske for the catch.
nthr
is created on line 293. Then a new one on line 316 shadows the outer one. This means that values set on the inner one will be lost when the scope ends, and on line 356, the result will always be falsy, and hence the code will never run.Fixes #16