Closed jonasbadstuebner closed 2 years ago
Checks are passing now. I improved the style if the pipeline too, to see the error.log in case a test fails.
It would fit the code before my changes better if I would change the max line width to 76, but I find this a weird number, so I suggest we keep it at 75.
I'm requesting your help because the pipeline does not do what I understand it should. The error it is throwing is not based on the current state of the code.
E.g. 127.0.0.1:12354 up
is written nowhere in the sanity.t file. Where does the pipeline get this from?
From pipeline logs:
# Primary Peers
# - 127.0.0.1:12354 up
# - 127.0.0.1:12355 up
# + 127.0.0.1:12354 UP
# + 127.0.0.1:12355 UP
Please review this again.
closes #90 As discussed in the above mentioned issue, this PR adds health check values like so:
It's checking the upstreams first, then the primary peers and the backup peers come last. It puts a 1 where the exposed metric is representing the current status of the checked target and a 0 to all the other statuses, so you always have all the metrics and you have no gaps in your metrics.
Also I fixed the sanity tests and improved the
make install
command and split up the prometheus tests to improve debugging abilities.