Closed velemas closed 2 years ago
zhuizhuhaomeng
commented
2 years ago This PR fixes issue #136 and breakage introduced by commit 5980ef9 seen in kubernetes/ingress-nginx#6504 on s390x.
Signed-off-by: Artiom Vaskov artiom.vaskov@ibm.com
@velemas would you please add s390 for ci just like https://github.com/openresty/luajit2/pull/137/files? only one line code is needed.
velemas
commented
2 years ago @zhuizhuhaomeng i will but before that it needs additional s390x fixes for changes introduced in commits c6f5ef649b645db9cf3d11d1b5c63602c49c6411 and bb0f24101565d34ea8b70fdec4dd3f3b35a70e7b (table traversal). I am preparing updates to allow s390x to pass all the tests from luajit2-test-suite with new table traversal.
velemas
commented
2 years ago @zhuizhuhaomeng sorry, i accidentally removed my fork, i will close this PR and create a new one with all the changes to pass the tests and CI enabled. New PR https://github.com/openresty/luajit2/pull/144
velemas
commented
2 years ago This PR fixes issue #136 and breakage introduced by commit 5980ef9 seen in kubernetes/ingress-nginx#6504 on s390x. Signed-off-by: Artiom Vaskov artiom.vaskov@ibm.com
@velemas would you please add s390 for ci just like https://github.com/openresty/luajit2/pull/137/files? only one line code is needed.
Actually i see another exception for archs other than amd64 (currently only arm64):
if [ ${TRAVIS_CPU_ARCH} != "arm64" ]; then PATH=/opt/luajit21/bin:$PATH prove -I. t; fi
This PR fixes issue https://github.com/openresty/luajit2/issues/136 and breakage introduced by commit 5980ef945c459625a21d8f397fb8a4cf043c1771 seen in https://github.com/kubernetes/ingress-nginx/issues/6504 on s390x.
Signed-off-by: Artiom Vaskov artiom.vaskov@ibm.com