openresty / meta-lua-nginx-module

Meta Lua Nginx Module supporting both Http Lua Module and Stream Lua Module
66 stars 20 forks source link

The make SUBSYS=xxx command should allow specify the output directory #12

Closed agentzh closed 6 years ago

agentzh commented 6 years ago

Right now, make SUBSYS=xxx always generate code into build/src/, this is not desired. Better make it possible to specify a DESTDIR variable.

agentzh commented 6 years ago

One usage is this:

make SUBSYS=http DESTDIR=../lua-nginx-modue/src 
make SUBSYS=stream DESTDIR=../stream-lua-nginx-modue/src

It is much more convenient for my workflow.

Oh, BTW, Makefile uses all-upper-case variable names for those variables which are supposed to be overridden from outside, while using all-lower-case names for variables for internal use only inside Makefile. You can refer to GNU make manual for more details on the naming convention. We'd better follow that.

agentzh commented 6 years ago

Sorry, it's me using all-lower-case form in this issue. Never mind about the lettercase then :)